This repository was archived by the owner on Oct 28, 2024. It is now read-only.
add testing #26
Merged
add testing #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
added
the
patch-version-bump-only
motivation: make sure library works as expected changes: * add a Sample target we can use for testing * add a test to make sure backtraces are printed as expected * make docker tests use a release version for a more realistic tests * update linux test generation script to work with release builds
ianpartridge
approved these changes
Mar 24, 2020
| let expectedError = UUID().uuidString | ||
| let pipe = Pipe() | ||
| let process = Process() | ||
| process.executableURL = URL(fileURLWithPath: ".build/release/Sample") |
Collaborator
There was a problem hiding this comment.
This is an SPM implementation detail and not guaranteed to be stable, but it's the best we can do.
Collaborator
There was a problem hiding this comment.
Oh actually, could we swift run Sample?
Collaborator
There was a problem hiding this comment.
should we need the path for something (ie. if we can't use swift run for some reason), this might work:
$ swift build --show-bin-path
/Users/johannes/devel/swift-nio/.build/x86_64-apple-macosx/debug
$ swift build --show-bin-path -c release
/Users/johannes/devel/swift-nio/.build/x86_64-apple-macosx/release
Collaborator
Author
There was a problem hiding this comment.
using swift run sounds like a great idea, I will try it!
Collaborator
Author
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: make sure library works as expected
changes: